Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new resolver for marking quizzes illegible and update quiz list to allow filtering on this #96

Merged
merged 3 commits into from
Jun 22, 2024

Conversation

danielemery
Copy link
Owner

Introduces the ideas of "Quiz Notes". At the moment this includes only marking quizzes as illegible but the same table will be used later to request corrects etc.

Adds a new resolver markQuizIllegible which adds a note against the given quiz. Also tracks the user that added the note and the time they added it.

Adds a new filter when listing quizzes excludeIllegible which either allows you to exclude quizzes that you have marked illegible or quizzes that anyone has marked illegible.

Currently does not surface the quiz notes anywhere but will likely later be surfaced as part of the quiz details resolver.

@danielemery danielemery linked an issue Jun 22, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 31.94%. Comparing base (5314cf1) to head (222c4fb).

Files Patch % Lines
src/quiz/quiz.persistence.ts 0.00% 8 Missing and 1 partial ⚠️
src/quiz/quiz.gql.ts 0.00% 4 Missing ⚠️
src/quiz/quiz.service.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
- Coverage   32.92%   31.94%   -0.98%     
==========================================
  Files          22       22              
  Lines         489      504      +15     
  Branches       75       78       +3     
==========================================
  Hits          161      161              
- Misses        318      332      +14     
- Partials       10       11       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielemery danielemery self-assigned this Jun 22, 2024
@danielemery danielemery added the feature New feature or request label Jun 22, 2024
@danielemery danielemery merged commit a691b71 into main Jun 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow marking a quiz as illegible
2 participants